Added an already running check

[zfs-nexenta/.git] / zfs-scrub

diff --git a/zfs-scrub b/zfs-scrub
index aff4a38ee5429f728e9772202d02f1322b7afce6..939c798b4c6339e2e0523a39903b2f0e513afd55 100755 (executable)
--- a/zfs-scrub
+++ b/zfs-scrub
@@ -1,19 +1,29 @@
 #!/bin/bash
 
 # Author: Alan J. Pippin
-# Description: This script will attempt to scrub each zfs pool
-#              given to it in the for loop. This script ensures
-#              That only 1 scrub operation is running at any given time.
-#              This serializes the zfs scrub process for each pool.
+# Description: This script will attempt to scrub a given pool.
+#              This script ensures that only 1 scrub operation is 
+#              running at any given time. This serializes the zfs 
+#              scrub process for any pool.
 
-PATH=/usr/sbin:/sbin:$PATH
+# source our configuration
+config="${0%/*}/zfs-scripts.conf"
+[ -e "${config}.dist" ] && . ${config}.dist
+[ -e "${config}" ] && . ${config}
 
+exec >> $logdir/zfs-scrub.log 2>&1
+
+pools="$*"
 maxsleeptime=360
-logfile=/var/log/zfs/zfs-scrub.log
 
-for i in tank storage
+if [ -z "$pools" ]; then
+   echo "-E- Usage: $0 <pools>"
+   exit 1
+fi
+
+for i in $pools
 do
-  # Check to see if this zfs filesystem has a scrub being performed on it now.
+  # Check to see if any zfs filesystem has a scrub being performed on it now.
   # If it does, we cannot perform more than one scrub operation at a time.
   while true; do
     zpool status | grep scrub: | grep "in progress" > /dev/null 2>&1
@@ -29,8 +39,33 @@ do
   done
 
   date=`date`
-  echo "$date: Scrub started for zfs pool $i" >> $logfile
+  echo "$date: Scrub started for zfs pool $i"
   zpool scrub $i
-  sleep 60
+
+  # Wait until the scrub completes, and check for any errors
+  while true; do
+    zpool status $i | grep scrub: | grep "in progress" > /dev/null 2>&1
+    if [ $? == 0 ]; then
+        # Our zpool scrub operation is still running
+        # Wait until it is done before continuing
+        ransleep=$(($RANDOM % $maxsleeptime))
+        sleep $ransleep
+    else
+        # Our scrub operation has completed
+        break
+    fi
+  done
+
+  date=`date`
+  echo "$date: Scrub completed for zfs pool $i"
+
+  # Check for any scrub errors
+  zpool status $i | grep scrub: | grep "with 0 errors" > /dev/null 2>&1
+  if [ $? != 0 ]; then
+    # The scrub found errors
+    zpool status $i | $mailx -s "zpool scrub $i found errors" $mailto 
+  fi 
 
 done
+
+